1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/mailsrvr.cpp

    From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Dec 13 00:10:42 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/8ede971ae8be2c67cbf4879e
    Modified Files:
    src/sbbs3/mailsrvr.cpp
    Log Message:
    Complete the BOOL->bool conversion

    This likely fixes the recently-introduced heap corruption (sizeof BOOL != sizeof bool).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri Dec 19 14:22:29 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/3003dde7678efdd9a000b731
    Modified Files:
    src/sbbs3/mailsrvr.cpp
    Log Message:
    Remove another destroy infinite loop.

    This one appears to actively make itself worse every time through
    the loop. :(

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Dec 30 22:20:09 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/74c037b2205ba9070e55ddc1
    Modified Files:
    src/sbbs3/mailsrvr.cpp
    Log Message:
    Fix mail archive feature

    Broken in commit f820805f0 (fixing Coverity issue, sigh)

    Once the mail archive directory existed (once successfully created), the function would just fail.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Jan 17 04:11:26 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/c5daf067bae2f7666c4ccfc2
    Modified Files:
    src/sbbs3/mailsrvr.cpp
    Log Message:
    Strip ctrl chars "B" mime-encoded words in incoming message header fields

    Per RFC2047: "Only printable and white space character data should be encoded using this scheme."

    Apparently TikTok doesn't follow that advice. Here's one example:

    68% #614159 (1741720) TikTok Header field contains control characters
    ...
    Subject 6C 69 76 6B 61 70 73 7A 6F 6F 20 70 6F 73 74 65 64 3A 20 4D 75 66 66 69 6E 20 73 61 69 64 20 0A 4E 6F 20 74 68 61 6E 6B 73 F0 9F AB A0

    Which expands to:

    "livkapszoo posted: Muffin said
    No thanks🫠"

    This could do weird things when the message is viewed (depending on the viewer) and triggers the chksmb error: Control Characters in Header Fields (!): 1

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wed Feb 11 17:27:28 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/47560c50d5d83383947c349a
    Modified Files:
    src/sbbs3/mailsrvr.cpp
    Log Message:
    Remove quotes from RCPT TO: <forward-path> before comparing to local names

    This resolve an issue observed with Thunderbird sending to local:<name>@bbs: Unknown User: <"local:name"@vert.synchro.net>.

    Presumably, Thunderbird is adding the quotes because of the colon. I've not seen this issue before, so perhaps this is new behavior of Thunderbird. In any case, RFC[2]821 specifies that the RCPT TO argument is a Mailbox and that the local-part of a Mailbox may be a quoted-string (instead of a dot-string). So, Synchronet hasn't been compliant in this regard all these years.

    No special parsing of \" is implemented since we don't support quotes in names anyway. RFC 821 says the character following a backslash (<x>) may be
    "any one of the 128 ASCII characters (no exceptions)" - that implies all control characters too, which sounds really dangerous. That language seems fixed in RFC 2821, but I'm not trying to solve all the crazy escaping possibilities in this simple commit.

    The original RCPT TO argument (with quotes, if present) is still stored for subsequent forwarding or whatever.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Feb 12 03:12:06 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/8409089bbc3b1e11c0d140f3
    Modified Files:
    src/sbbs3/mailsrvr.cpp
    Log Message:
    Cache the dnsbl_exempt.cfg file (mine is 2MB)

    ... this file was being read multiple times for every incoming SMTP message

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Feb 12 16:38:59 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/63ee13b03befd229da39f7d1
    Modified Files:
    src/sbbs3/mailsrvr.cpp
    Log Message:
    Insure dnsbl_result is always zero-initialized

    Fix recently-introduced bug

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Feb 13 00:34:20 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/3b05d005e25a668fdd78aa20
    Modified Files:
    src/sbbs3/mailsrvr.cpp
    Log Message:
    Always clear the "from extension" for newly created bounce messages

    This bug caused chksmb reported errors in bounced messages (e.g. from listserver):

    97% #635909 (30AEF20) Mail Delivery Subsystem From extension mismatch MSGERR: From extension ((null)) does not match index (1)

    packing or running fixsmb on the mail base would correct the index, but this
    is the real fix.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Mar 3 00:36:21 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/29763a38c718800231a135d1
    Modified Files:
    src/sbbs3/mailsrvr.cpp
    Log Message:
    Log the message relative number (and total msgs waiting) for POP3 retrievals

    giving some indication of progress towards the last message waiting for the user

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Mar 12 14:38:27 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/44f1d233a67e7ebf1a15586b
    Modified Files:
    src/sbbs3/mailsrvr.cpp
    Log Message:
    Reset a couple of mail-specific filter/listfile objects during cleanup()

    Restoring pre commit c8490b7429f behavior with regards to these lists, only noticable in logged/printed stats.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed May 6 19:41:53 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/92ae6263408f0ddd5d05d802
    Modified Files:
    src/sbbs3/mailsrvr.cpp
    Log Message:
    mailsrvr: bound sockmimetext line scan with strnlen (CID 639931)

    The inner while-loop walks (*np + len) up to RFC822_MAX_LINE_LEN bytes
    relying on the embedded NUL test to stop early. When np points at the
    "\r\n" literal used as the empty-body fallback (issue #822), Coverity
    loses track of the literal's length and reports a 997-byte OVERRUN.
    Compute the scan length up-front with strnlen so the bound is explicit; behavior is unchanged but the OVERRUN false-positive is silenced.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thu May 14 03:17:17 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/52099548d7f5782b818bdbe7
    Modified Files:
    src/sbbs3/mailsrvr.cpp
    Log Message:
    mailsrvr: POP3 reply -ERR (not !UNSUPPORTED) to USER/PASS in TRANSACTION state

    Some clients (e.g. Thunderbird) reuse an already-authenticated TCP socket
    and re-issue USER/PASS. Per RFC 1939 these are AUTHORIZATION-state-only commands, so respond with a plain -ERR and keep the session alive,
    matching Dovecot/Courier behavior and suppressing the misleading
    "!UNSUPPORTED COMMAND" log notice.

    Refs main/sbbs#1123

    Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Jul 27 02:09:08 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/7e492e0eeb8e9cd553fb6a2f
    Modified Files:
    src/sbbs3/mailsrvr.cpp
    Log Message:
    mail: only auto-detect an IPv4 DNS server address

    dns_getmx() takes the server as a DWORD, so an IPv6 address cannot reach
    it: resolve_ip() returns INADDR_NONE, the send is abandoned with the
    message left for a later attempt, and "INVALID DNS server address" is
    logged. get_dns_server() picked at random from every address getNameServerList() reported, so a host with resolvers of both families
    failed on some sends and not others -- and on Windows the list can now
    include IPv6 servers where it never could before.

    Filter to the addresses the look-up can use, and say so when a detected
    list holds none of them, rather than leaving the caller to report an empty address as invalid.

    The precision on the adjacent sprintf() was one greater than the room the buffer has for text.

    Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Jul 27 02:10:11 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/b19bdde0674b55673b4d1005
    Modified Files:
    src/sbbs3/mailsrvr.cpp
    Log Message:
    mailsrvr: log the offending command on invalid POP3 message numbers

    The POP3 LIST/UIDL, RETR/TOP, and DELE handlers logged only the parsed
    message number when rejecting an out-of-range argument. When the argument
    is missing or non-numeric, strtoul() yields 0, so the log always reads
    "INVALID message #0" with no indication of what the client actually sent
    -- exactly the case where the command text is needed to diagnose it.

    Log the command line and the mailbox message count, matching the detail
    already present in the successful-retrieval log message.

    Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net